Add beautiful_soup_parser option#206
Merged
AlexVonB merged 4 commits intomatthewwithanm:developfrom Mar 29, 2025
Merged
Conversation
Collaborator
|
Hey Vincent, thanks for your PR! Looks great! Could you please add the parameter to the command line interface? https://github.com/matthewwithanm/python-markdownify/blob/develop/markdownify/main.py As soon as this is added I will merge this. Thanks again! |
Contributor
Author
Collaborator
|
Thanks a lot! 🥳 |
Wuhall
pushed a commit
to Wuhall/python-markdownify
that referenced
this pull request
May 21, 2025
* add beautiful_soup_parser option * add Beautiful Soup parser argument to command line --------- Co-authored-by: Vincent Kelleher <vincent.kelleher-ext@francetravail.fr> Co-authored-by: AlexVonB <AlexVonB@users.noreply.github.com>
G-Rath
pushed a commit
to G-Rath/python-markdownify
that referenced
this pull request
Jul 14, 2025
* add beautiful_soup_parser option * add Beautiful Soup parser argument to command line --------- Co-authored-by: Vincent Kelleher <vincent.kelleher-ext@francetravail.fr> Co-authored-by: AlexVonB <AlexVonB@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
As per my issue #205 and #58, I propose the following changes to allow users to choose which parser they want to use with BeautifulSoup 😇
As a quick refresher, at the moment, only
html.parseris available as the default HTML parser when using themarkdownify(..)method. It's still possible to use theMarkdownConverter(options).convert_soup(..)method but having both solution si more convenient IMHO.I haven't written any specific test for other kinds of HTML parsers as I didn't want to add extra dependencies to this project. If required I could add development dependencies only to run those specific tests.
Thanks @AlexVonB for your help with this subject 🙏