Support video tag with poster attribute#189
Merged
AlexVonB merged 4 commits intomatthewwithanm:developfrom Feb 28, 2025
Merged
Conversation
AlexVonB
requested changes
Feb 17, 2025
Collaborator
AlexVonB
left a comment
There was a problem hiding this comment.
Thanks for your contribution! If you have time for it, please check the change request.
One thing we should probably ignore is the <source> tag that can occur inside the video tag. But if you have a good idea how to include this as well, feel free to do so!
Wuhall
pushed a commit
to Wuhall/python-markdownify
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds support for the
<video>tag by converting theposterattribute into a Markdown image.https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
Thanks.
Summary (Copilot generated
)
This pull request adds support for converting HTML video elements to Markdown format in the
markdownifylibrary. The changes include a new conversion method and corresponding tests.New feature: Video element conversion
markdownify/__init__.py: Added aconvert_videomethod to handle the conversion of HTML video elements to Markdown. This method checks for the presence ofsrcandposterattributes and formats the output accordingly.Testing the new feature
tests/test_conversions.py: Added atest_videofunction to verify the correct conversion of video elements with different attributes to Markdown.