Avoid stripping nonbreaking spaces#188
Merged
chrispy-snps merged 2 commits intomatthewwithanm:developfrom Feb 19, 2025
Merged
Conversation
Nonbreaking spaces should be preserved in places such as the start of a paragraph or blockquote, so change various places to strip only ASCII `' \t\r\n'`. There may be other places that should also avoid stripping nonbreaking spaces (or, conversely, where *trailing* such spaces could safely be stripped even if they no longer are after this change), but this seems a reasonable starting point to fix issues in this area.
Collaborator
|
@AlexVonB - I think this is a good change, as browsers do not collapse non-breaking spaces either. Are you also agreeable to merging it? |
AlexVonB
approved these changes
Feb 19, 2025
Wuhall
pushed a commit
to Wuhall/python-markdownify
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nonbreaking spaces should be preserved in places such as the start of a paragraph or blockquote, so change various places to strip only ASCII
' \t\r\n'. There may be other places that should also avoid stripping nonbreaking spaces (or, conversely, where trailing such spaces could safely be stripped even if they no longer are after this change), but this seems a reasonable starting point to fix issues in this area.