when computing <ol><li> numbering, ignore non-<li> previous siblings#183
Merged
chrispy-snps merged 1 commit intomatthewwithanm:developfrom Feb 4, 2025
Merged
Conversation
Signed-off-by: chrispy <chrispy@synopsys.com>
AlexVonB
approved these changes
Feb 4, 2025
Collaborator
AlexVonB
left a comment
There was a problem hiding this comment.
Good catch! Could be quadratic and take much compute on very(!) long lists, but that should be no problem in the day-to-day usecases.
Collaborator
Author
|
Thanks @AlexVonB! I was also mindful of the quadratic approach and I admit this fix still makes me somewhat uncomfortable, but we can always improve the code if someone really finds a case where this matters. :) |
Wuhall
pushed a commit
to Wuhall/python-markdownify
that referenced
this pull request
May 21, 2025
…atthewwithanm#183) Signed-off-by: chrispy <chrispy@synopsys.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, numbering for
<li>items inside<ol>count all previous siblings when computing the number:This pull request updates the code to consider only preceding
<li>elements:A unit test is added to check this case.