scripts/fetch-pricing-data.ts (1)

1-18: Consider camelCase filename for this utility script.

Rename to fetchPricingData.ts and update the prebuild script to align with file-naming conventions.

As per coding guidelines "Use camelCase for utility file names".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/fetch-pricing-data.ts` around lines 1 - 18, The script file is using
snake-case filename "fetch-pricing-data.ts"; rename it to camelCase
"fetchPricingData.ts" and update any references (e.g., the executable shebang
import entry, build scripts and the prebuild npm script that invokes this file)
so the module path matches the new name; ensure imports/paths that compute
__filename, __dirname, OUTPUT_PATH and LITELLM_PRICING_URL remain unchanged and
the prebuild script in package.json points to "./scripts/fetchPricingData.ts"
(or equivalent) after renaming.

src/main/utils/jsonl.ts (1)

219-220: Consider moving imports to the top of the file.

The fs and path imports are placed mid-file (after line 214). While this works in Node.js due to hoisting, placing imports at the top of the file is the standard convention and improves readability.

♻️ Suggested change

Move these imports to the top of the file with other imports:

 import { isCommandOutputContent, sanitizeDisplayContent } from '@shared/utils/contentSanitizer';
 import { createLogger } from '@shared/utils/logger';
+import * as fs from 'fs';
+import * as path from 'path';
 import * as readline from 'readline';

Then remove lines 219-220.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/main/utils/jsonl.ts` around lines 219 - 220, The fs and path imports are
located mid-file instead of with the other imports; move the two import
statements for fs and path to the top of src/main/utils/jsonl.ts alongside the
other imports and remove the duplicated lines at their current location
(references: import identifiers "fs" and "path" in this file). Ensure any code
that uses fs or path continues to work after relocation and run lint/type checks
to confirm no import-order issues.

test/main/utils/costCalculation.test.ts (1)

409-449: Add a noop comment to satisfy the linter.

The ESLint rule @typescript-eslint/no-empty-function flags the empty arrow function. While this is intentional to suppress console output, adding a comment makes the intent explicit.

🧹 Proposed fix

-      const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+      const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {
+        // Intentionally empty - suppress expected error output during test
+      });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/main/utils/costCalculation.test.ts` around lines 409 - 449, The empty
arrow function used in the console.error spy (vi.spyOn(console,
'error').mockImplementation(() => {})) triggers
`@typescript-eslint/no-empty-function`; replace the empty implementation with a
no-op that contains a comment (e.g., mockImplementation(() => { /* noop:
suppress expected error */ })) so the linter is satisfied while preserving
behavior in the test that calls freshCalculateMetrics and asserts
metrics.costUsd and console.error usage.

src/main/utils/jsonl.ts (2)

268-270: Use the existing logger for consistency.

The file already imports and uses logger from @shared/utils/logger (line 35). Using console.error here is inconsistent with the rest of the file.

♻️ Proposed fix

   } catch (error) {
-    console.error('Failed to load pricing data:', error);
+    logger.error('Failed to load pricing data:', error);
     // Return empty object if pricing data can't be loaded
     pricingCache = {};

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/main/utils/jsonl.ts` around lines 268 - 270, Replace the console.error
call in the pricing-data load catch block with the shared logger: locate the
try/catch that loads pricing data (the catch currently logs "Failed to load
pricing data:" using console.error) and change it to use logger.error, passing
the same message and the error object (e.g., logger.error('Failed to load
pricing data:', error)); keep the existing behavior of returning an empty object
on failure. Ensure the import-sourced logger (from `@shared/utils/logger`) is used
consistently in that catch block.

---

219-220: Move imports to the top of the file.

The fs and path imports are placed mid-file, which violates the import organization convention. As per coding guidelines, imports should be organized at the top of the file in order: external packages, path aliases, then relative imports.

♻️ Proposed fix

Add these imports at the top of the file with other external packages (after line 12):

import * as fs from 'fs';
import * as path from 'path';

Then remove lines 219-220.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/main/utils/jsonl.ts` around lines 219 - 220, The mid-file imports "fs"
and "path" should be moved into the top import block with the other external
packages: remove the duplicate imports currently declared as import * as fs from
'fs'; import * as path from 'path'; from their current location and add them to
the top of the file alongside the other external imports so that all external
modules (including fs and path) are grouped before path-alias and relative
imports.