Skip to content

Draft: Synapse and MSC2716 edits (explore the DAG)#1

Closed
MadLittleMods wants to merge 3 commits intomatrix-org:mainfrom
MadLittleMods:2716-tardis-synapse
Closed

Draft: Synapse and MSC2716 edits (explore the DAG)#1
MadLittleMods wants to merge 3 commits intomatrix-org:mainfrom
MadLittleMods:2716-tardis-synapse

Conversation

@MadLittleMods
Copy link

@MadLittleMods MadLittleMods commented Feb 2, 2021 •
edited
Loading

Edits to make TARDIS work with Synapse while writing Complement tests for MSC2716.

Changes needed in Synapse

In Synapse, comment out all of the dropped fields in the event serialization in Synapse synapse/events/utils.py#L253-L259.

Changes needed in your Complement test

contextRes := alice.MustDoFunc(t, "GET", []string{"_matrix", "client", "r0", "rooms", roomID, "context", eventStar}, client.WithContentType("application/json"), client.WithQueries(url.Values{
	"limit": []string{"100"},
}))
contextResBody := client.ParseJSON(t, contextRes)
logrus.WithFields(logrus.Fields{
	"contextResBody": string(contextResBody),
}).Error("context res")
Previous before functional client API 
contextRes := alice.MustDoRaw(t, "GET", []string{"_matrix", "client", "r0", "rooms", roomID, "context", eventStar}, nil, "application/json", url.Values{
	"limit": []string{"100"},
})
contextResBody := client.ParseJSON(t, contextRes)
logrus.WithFields(logrus.Fields{
	"contextResBody": string(contextResBody),
}).Error("context res")

Copy the output of that log line and paste it in the src/context-response.json file. (Replace the \" with ")

@MadLittleMods
Synapse and MSC2716 edits
de82a24 
Edits to make TARDIS work with Synapse while writing Complement tests for [MSC 2716](matrix-org/matrix-spec-proposals#2716).

 - matrix-org/synapse#9247
 - matrix-org/complement#68
MadLittleMods
MadLittleMods commented Feb 2, 2021
View reviewed changes
src/context-response.json
@@ -0,0 +1,629 @@
{
Copy link
Author

@MadLittleMods MadLittleMods Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data produces the following chart:

This was referenced Feb 2, 2021
Merged
Merged
MadLittleMods added a commit to matrix-org/synapse that referenced this pull request Feb 2, 2021
@MadLittleMods
Remove origin_server_ts in favor of spec'ed ts query param
bf90053 
Also edits for TARDIS visualation: matrix-org/tardis#1
@MadLittleMods MadLittleMods changed the title Draft: Synapse and MSC2716 edits Draft: Synapse and MSC2716 edits (explore the DAG) Feb 2, 2021
MadLittleMods
MadLittleMods commented Feb 2, 2021
View reviewed changes
src/index.js
nodes.append('text')
.text((d) => d.data.type)
.text((d) => {
return `${d.data.type} - ${d.data.content && d.data.content.body} (depth=${d.data.depth})`;
Copy link
Author

@MadLittleMods MadLittleMods Feb 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated DAG visualization with depth. See matrix-org/complement#68 (comment) for full context

MadLittleMods added a commit to matrix-org/synapse that referenced this pull request Feb 5, 2021
@MadLittleMods
Remove debugging fields for TARDIS visualization
afa5e5d 
Related matrix-org/tardis#1
@MadLittleMods MadLittleMods mentioned this pull request Jun 25, 2021
Merged
4 tasks
@MadLittleMods MadLittleMods mentioned this pull request Jul 20, 2021
Merged
4 tasks
@MadLittleMods MadLittleMods mentioned this pull request Jul 29, 2021
Merged
4 tasks
@MadLittleMods MadLittleMods mentioned this pull request Dec 16, 2021
Open
@kegsay
Copy link
Member

kegsay commented Jan 3, 2025

Stale, closing.

@kegsay kegsay closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MadLittleMods @kegsay