Fix "Event with an invalid signature in the send_join response should not cause room join to fail"#973
Merged
neilalexander merged 2 commits intodevelopfrom Oct 14, 2020
Merged
Conversation
… not cause room join to fail"
kegsay
approved these changes
Oct 14, 2020
Member
kegsay
left a comment
There was a problem hiding this comment.
This is the test I pointed @erikjohnston at when I was last in the office. This change matches the test description far better.
richvdh
added a commit
that referenced
this pull request
Oct 16, 2020
For the second time this week (#972 and #973), I've found myself wondering why a test was failing and discovered that it is due to it relying on new functionality in Future 0.45. I guess we may as well bump the dep as try to keep our tests backwards-compatible, particularly given the CI uses the latest version.
richvdh
added a commit
that referenced
this pull request
Oct 19, 2020
For the second time this week (#972 and #973), I've found myself wondering why a test was failing and discovered that it is due to it relying on new functionality in Future 0.45. I guess we may as well bump the dep as try to keep our tests backwards-compatible, particularly given the CI uses the latest version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two changes:
/sync, instead of immediately hitting/state, since the roomserver might not know about that room yet