Merged
Conversation
this seems to have looped waiting for presence to turn up ever since it was first written, but as far as I can tell, the loop has never done anything, because where we don't know presence, we always make up an "offline" status. Anyway, this seems to make it more reliable.
erikjohnston
approved these changes
Oct 6, 2020
richvdh
added a commit
that referenced
this pull request
Oct 6, 2020
A follow-up from #965, in which it turns out I didn't really know what I was doing. Anyway, I think I've *really* deflaked this one this time.
richvdh
added a commit
that referenced
this pull request
Oct 7, 2020
A follow-up from #965, in which it turns out I didn't really know what I was doing. Anyway, I think I've *really* deflaked this one this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this seems to have looped waiting for presence to turn up ever since it was
first written, but as far as I can tell, the loop has never done anything,
because where we don't know presence, we always make up an "offline" status.
Anyway, this seems to make it more reliable.