Allow filename= formatted Content-Disposition#892
Merged
neilalexander merged 5 commits intodevelopfrom Jun 16, 2020
Merged
Conversation
richvdh
reviewed
Jun 16, 2020
tests/51media/01unicode.pl
Outdated
| my ( $cd_params ) = @_; | ||
| assert_eq( $cd_params->{'filename*'}, "utf-8''$FILENAME_ENCODED", "filename*" ); | ||
|
|
||
| if (exists( $cd_params->{'filename'} )) { |
Member
There was a problem hiding this comment.
could you add a comment saying what this is doing?
Contributor
Author
There was a problem hiding this comment.
Have added some comments.
anoadragon453
added a commit
that referenced
this pull request
Aug 4, 2020
* origin/release-v1.16.0: (21 commits) Add missing DB Fix typing leak test to use /sync and true Use /sync and not /events for invite tests Use true not 1 when setting typing Revert "Merge mainline release v1.15.1 into dinsic" Use matrix_invite_user_to_room_synced on remote invite tests Remove unused variables. (#899) remove testing file Update tests/30rooms/20typing.pl Make invite tests use /sync not room /initialSync Refactor to log typing events and bail earlier perldoc Get the operator correct Don't fail the test if there are users typing on the stop typing test Make typing tests use /sync not /events Remove dependency on room initial sync for name/topic tests Fix a warning about referencing a scalar. (#893) Add event ID to /send_join requests rather than 'xxx' Implement MSC2625 (unread counters) (#890) Allow filename= formatted Content-Disposition (#892) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
Content-Dispositionheader, Synapse usesinline; filename*=utf-8''foobut Dendrite usesinline; filename=utf-8\"foo\".This updates the test to support both, rather than just the former.
Additional info in Synapse's own source code: https://github.com/matrix-org/synapse/blob/a3f11567d930b7da0db068c3b313f6f4abbf12a1/synapse/rest/media/v1/_base.py#L122-L140