Add some tests to check for adding/removing aliases#792
Merged
Conversation
Make sure that users can add and remove aliases even if the m.room.aliases PL is restricted.
| uri => "/r0/directory/room/$room_alias", | ||
|
|
||
| content => { room_id => $room_id }, | ||
| test "Regular users can add and delete aliases when m.room.aliases is restricted", |
Member
There was a problem hiding this comment.
Will this only pass on old room versions?
Member
Author
There was a problem hiding this comment.
it should pass on all room versions. The idea of MSC2260 is that you can still add aliases, but if you don't have perms in the room there will be no m.room.aliases event.
erikjohnston
approved these changes
Jan 29, 2020
anoadragon453
added a commit
that referenced
this pull request
Mar 23, 2020
…ease-v1.10.x * origin/release-v1.10.0: remove checks on m.room.aliases (#801) Remove test which uses unspecced /events?dir=b (#794) Add some tests to check for adding/removing aliases (#792) Add test for ensuring power levels are correctly handled during upgrade (#777) Test that fetching device correctly resyncs (#791) Add support for experimental MSC2260 room version (#790) Fix power levels being sent as strings (#789) Don't respond with 503 as server will be marked as down. (#788) Test Synapse with MAU limits enabled. (#782) Fix docker/push.sh and make it echo commands Change postgres in docker image to use C collation/ctype. (#783) Add a passing test for recovery from gappy device list updates (#761)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that users can add and remove aliases even if the m.room.aliases PL
is restricted.