Update appservice tests to check for access token in header vs query params#1362
Merged
Update appservice tests to check for access token in header vs query params#1362
Conversation
Contributor
Author
|
Seems that the Dendrite failures are not related? |
Contributor
|
Sanity check: the spec says
|
Contributor
I concur, looks like Dendrite is failing on the main branch with the same set of tests. |
DMRobertson
approved these changes
Aug 3, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Seems sane, and I can see similar snippets in sytest elsewhere.
Contributor
Author
|
Merged #1362 into develop, thanks for the review! |
MatMaul
pushed a commit
that referenced
this pull request
Aug 4, 2023
MatMaul
pushed a commit
that referenced
this pull request
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synapse v1.81.0 deprecated application service authorization via query parameters - authorization should now be sent via Authorization header. This PR (I hope, Perl is not my native language) changes two appservice tests to stop checking the query params for the access token and to check for them instead in the Authorization header.