Script to convert TAP to GHA workflow commands#1052
Conversation
I plan to wire this into the github actions workflow, to make it easier to see what broke.
scripts/tap_to_text.pl
Outdated
| my $number = $result->number; | ||
| my $description = $result->description; | ||
|
|
||
| print "${RED}FAILURE:$RESET_FG #$number: $description\n"; |
There was a problem hiding this comment.
I wonder if we should look for GITHUB_ACTIONS being set in the environment, and if so, log the error in a format that it will detect?
E.g., print ("::error::#$number: $description\n");
There was a problem hiding this comment.
Ahh I looked for a document like that, and failed to find one.
I think it makes sense for this to be GHA-specific, rather that having magic based on the environment. I'll have a go at this.
|
Output looks good to me. Wonder if this should live here or in Synapse where it's easier to iterate on, but 🤷. Wonder if the grouping is strictly necessary, but it doesn't hurt. I have a stripped down PR running at matrix-org/synapse#10090 which I'll re-start until it naturally hits a failure just so we can have a "real" example of how this script behaves. |
It can be useful for other homeserver implementations, so should probably live in the Sytest repo. |
|
Actually, one requested change: could this return a non-0 exit code when failures are detected? |
|
For context, this is what the output from this script looks like 🎉
|
Yup absolutely this. Likewise, I can't see other test frameworks being silly enough to write TAP output. |
your wish is my command. If you're happy with this can you mash the merge button? |
…10094) ... using the script from matrix-org/sytest#1052
I plan to wire this into the github actions workflow, to make it easier to see
what broke.