This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Lint the contrib/ directory in CI and linting scripts, add synctl to linting script#7914
Merged
anoadragon453 merged 7 commits intodevelopfrom Jul 20, 2020
Merged
Lint the contrib/ directory in CI and linting scripts, add synctl to linting script#7914anoadragon453 merged 7 commits intodevelopfrom
anoadragon453 merged 7 commits intodevelopfrom
Conversation
clokep
reviewed
Jul 20, 2020
Member
clokep
left a comment
There was a problem hiding this comment.
I don't see a reason not to run this in CI flake8 contrib runs instantly for me.
Member
Author
Indeed, I was worried about CI times but you're right in the fact that the difference is negligible :) |
This is for consistency with the linting code in tox.ini
Member
Author
|
I've added Line 129 in 1f98886 |
clokep
approved these changes
Jul 20, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'de119063f': (31 commits) Convert room list handler to async/await. (#7912) Element CSS and logo in email templates (#7919) Lint the contrib/ directory in CI and linting scripts, add synctl to linting script (#7914) Remove unused code from synapse.logging.utils. (#7897) Fix a typo in the sample config. (#7890) Fix deprecation warning: import ABC from collections.abc (#7892) Change sample config's postgres user to synapse_user (#7889) Fix deprecation warning due to invalid escape sequences (#7895) Remove Ubuntu Eoan that is now EOL (#7888) Fix the trace function for async functions. (#7872) Add help for creating a user via docker (#7885) Switch to Debian:Slim from Alpine for the docker image (#7839) Stop using 'device_max_stream_id' (#7882) Fix TypeError in synapse.notifier (#7880) Add a default limit (of 100) to get/sync operations. (#7858) Change "unknown room ver" logging to warning. (#7881) Convert device handler to async/await (#7871) Convert synapse.app to async/await. (#7868) Convert _base, profile, and _receipts handlers to async/await (#7860) Add admin endpoint to get members in a room. (#7842) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs
isort,flake8andblackover thecontrib/directory. We've decided not to include it in CI for now as we try to keep CI runtimes down, and this directory is rarely changed anyways.Fixes #7910