This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add some metrics for inbound and outbound federation processing times#7755
Merged
erikjohnston merged 5 commits intodevelopfrom Jun 30, 2020
Merged
Add some metrics for inbound and outbound federation processing times#7755erikjohnston merged 5 commits intodevelopfrom
erikjohnston merged 5 commits intodevelopfrom
Conversation
This tracks the time between the event is persisted and it being sent to destination servers (to remote homeservers or application servers).
84c5580 to
5f7a5c0
Compare
clokep
reviewed
Jun 30, 2020
clokep
reviewed
Jun 30, 2020
| self._send_pdu(event, destinations) | ||
|
|
||
| now = self.clock.time_msec() | ||
| ts = await self.store.get_received_ts(event.event_id) |
Member
There was a problem hiding this comment.
Is there any concern about how much latency this will add by hitting the database again?
Member
Author
There was a problem hiding this comment.
Yes, though I think in this case its a very simple query and will be dwarfed by the complexity of the get_hosts_in_room query above
clokep
reviewed
Jun 30, 2020
changelog.d/7755.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Add some metrics for inbound and outbound federation latencies. | |||
Member
There was a problem hiding this comment.
Is it worth mentioning the metric names in case people want to use them?
clokep
approved these changes
Jun 30, 2020
Member
clokep
left a comment
There was a problem hiding this comment.
This seems fine. I'm guessing this is to help figure out what part of the federation sender is going slow?
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Member
Author
And for some potential KPIs |
erikjohnston
added a commit
that referenced
this pull request
Jul 1, 2020
Introduced in #7755, not yet released.
erikjohnston
added a commit
that referenced
this pull request
Jul 1, 2020
Introduced in #7755, not yet released.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'dc80a0762': 1.16.0rc1 Back out MSC2625 implementation (#7761) Additional configuration options for auto-join rooms (#7763) Add some metrics for inbound and outbound federation processing times (#7755) Explain the purpose of the "tests" conditional dependency requirement (#7751) Add another yield point to state res v2 (#7746) Move flake8 to end. Don't exit script on failure (#7738) Make tox actions work on Debian 10 (#7703) Yield during large v2 state res. (#7735) add org.matrix.login.jwt so that m.login.jwt can be deprecated (#7675) Set Content-Length for Metrics requests (#7730) Sync ignored table names in synapse_port_db to current database schema (#7717) Allow local media to be marked as safe from being quarantined. (#7718) Convert directory handler to async/await (#7727) Speed up state res v2 across large state differences. (#7725)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These metrics measure: