Conversation
All major browser support them as of 2016.
|
This kind of grew a bit, but should be easily reviewable commit by commit. Please let me know if there are any questions! I made some style changes for consistency, but we can change the style if we want to! |
Filed matrix-org/matrix-doc#2620 to look into this issue. |
ftr, if we were after style guides, I'd follow those from the matrix-react-sdk; but I think that what you've done here is pretty consistent with that. |
Seems to follow that, yes. 👍 Thanks! |
* commit '03619324f': Create a ListenerConfig object (#7681) Fix changelog wording 1.15.1 Wrap register_device coroutine in an ensureDeferred (#7684) Ensure the body is a string before comparing push rules. (#7701) Ensure etag is a string for GET room_keys/version response (#7691) Update m.id.phone to use 'phone' instead of 'number' (#7687) Fix "There was no active span when trying to log." error (#7698) Enable 3PID add/bind/unbind endpoints on r0 routes Discard RDATA from already seen positions. (#7648) Replace iteritems/itervalues/iterkeys with native versions. (#7692) Fix warnings about losing log context during UI auth. (#7688) Fix a typo when comparing the URI & method during UI Auth. (#7689) Remove "user_id" from GET /presence. (#7606) Increase the default SAML session expirary time to 15 minutes. (#7664) fix typo in sample_config.yaml (#7652) Take out a lock before modifying _CACHES (#7663) Add option to enable encryption by default for new rooms (#7639) Clean-up the fallback login code. (#7657)
This handles a review comment (#7629 (comment)) and a bunch of other misc. changes to the fallback login code to with an aim to:
There should be no functional changes in this PR.
I do note that the spec says:
But it seems the code calls
window.matrixLogin.onLoginunless I'm missing something?