This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Update the room member handler to use async/await.#7507
Merged
Conversation
richvdh
approved these changes
May 15, 2020
Member
richvdh
left a comment
There was a problem hiding this comment.
lgtm, assuming a PR which fixes the docstrings which claim that these functions return Deferred is on its way :)
Member
Author
I cleaned those up at the same time as doing type hints, all of it together just got a bit bigger than I wanted so put this one up first. :) |
phil-flex
pushed a commit
to phil-flex/synapse
that referenced
this pull request
Jun 16, 2020
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the room member (and worker) handler to async/await.
This was pretty straight-forward, but the sub-class made it a little tricky. Some of the types and such a bit funky. I'll follow this up with type hints.