This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Attempt to clarify Python version requirements#7161
Merged
Conversation
In particular, we depend on `typing.TYPE_CHECKING`, which is only present in 3.5.2. It turns out that Ubuntu Xenial, despite having a package called `python 3 (3.5.1-3)`, actually has python 3.5.2, so I think this is fine.
anoadragon453
approved these changes
Mar 27, 2020
Member
anoadragon453
left a comment
There was a problem hiding this comment.
lgtm. Newsfile please? :)
Member
Author
|
I decided to merge this to master to get it out asap, so a newsfile wouldn't really be appropriate. |
anoadragon453
added a commit
that referenced
this pull request
Apr 2, 2020
* master: 1.12.1 Note where bugs were introduced 1.12.1rc1 Newsfile Rewrite changelog Add changelog Only import sqlite3 when type checking Fix another instance Only setdefault for signatures if device has key_json Fix starting workers when federation sending not split out. Attempt to clarify Python version requirements (#7161) Improve the UX of the login fallback when using SSO (#7152) Update the wording of the config comment Lint Changelog Regenerate sample config Whitelist the login fallback by default for SSO
phil-flex
pushed a commit
to phil-flex/synapse
that referenced
this pull request
May 15, 2020
In particular, we depend on `typing.TYPE_CHECKING`, which is only present in 3.5.2. It turns out that Ubuntu Xenial, despite having a package called `python 3 (3.5.1-3)`, actually has python 3.5.2, so I think this is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, we depend on
typing.TYPE_CHECKING, which is only present in3.5.2.
It turns out that Ubuntu Xenial, despite having a package called
python 3 (3.5.1-3), actually has python 3.5.2, so I think this is fine.