This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add options to disable setting profile info for prevent changes.#7053
Merged
babolivier merged 12 commits intomatrix-org:developfrom Mar 10, 2020
Merged
Add options to disable setting profile info for prevent changes.#7053babolivier merged 12 commits intomatrix-org:developfrom
babolivier merged 12 commits intomatrix-org:developfrom
Conversation
babolivier
suggested changes
Mar 9, 2020
babolivier
suggested changes
Mar 10, 2020
Contributor
babolivier
left a comment
There was a problem hiding this comment.
Just one last bit, and then it's probably good to go :)
Co-Authored-By: Brendan Abolivier <github@brendanabolivier.com>
babolivier
approved these changes
Mar 10, 2020
Contributor
babolivier
left a comment
There was a problem hiding this comment.
Looks like it's good to go! Thanks again for your contribution :)
Member
|
I'm afraid I'm going to back this out for now: the sample configuration options don't follow the conventions: in particular they should make it clear what the defaults are, and give examples ready to be uncommented. This is really, really important, because inconsistency in the sample config makes it very hard for users to understand. |
Member
|
@dklimpel please could you resubmit this PR with updated text for the sample config? |
Contributor
Author
|
OK. I can do ist. |
4 tasks
phil-flex
pushed a commit
to phil-flex/synapse
that referenced
this pull request
Apr 15, 2020
…es. (matrix-org#7053)" This reverts commit 54dd286, reversing changes made to 6640460.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '6a3504636': (29 commits) Revert "Add options to disable setting profile info for prevent changes. (#7053)" Populate the room version from state events (#7070) Fix buggy condition in account validity handler (#7074) Use innerText instead of innerHTML Add type annotations and comments to auth handler (#7063) Lint Put the file in the templates directory Update wording and config Changelog Move the default SAML2 error HTML to a dedicated file Refactor a bit Also don't fail on aliases events in this case Lint Changelog Also don't filter out events sent by ignored users when checking state visibility Fix condition Don't filter out dummy events when we're checking the visibility of state Update sample_config.yaml Update synapse/config/registration.py lint, fix tests ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for: #5267
Code from #3179 and #3180 with additional tests
EventStoretoEventWorkerStore.".code blocks.Signed-off-by: Dirk Klimpel dirk@klimpel.org