This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Move MSC2432 stuff onto unstable prefix#6948
Merged
Conversation
Hide this under an unstable namespace, and add a feature flag to /versions
erikjohnston
approved these changes
Feb 19, 2020
| r"^/_matrix/client/unstable/org\.matrix\.msc2432" | ||
| r"/rooms/(?P<room_id>[^/]*)/aliases" | ||
| ), | ||
| ] |
Member
There was a problem hiding this comment.
At some point we may want an equivalent client_patterns for /unstable/...
Member
Author
There was a problem hiding this comment.
I think client_patterns is responsible for a whole bunch of unnecessary clutter in the #5118 department.
What I would like to see is putting strings rather than compiled REs into PATTERNs, to save some boilerplate, but I decided to shelve it for now.
There was a problem hiding this comment.
This is inconsistent with the Client-Server API Spec and the API Playground.
Member
|
This is part of #6898. |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's not in the spec yet, so needs to be
unstable. Also add a feature flag for it. Also add a test for admin users.