This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix stacktraces when using ObservableDeferred and async/await#6836
Merged
erikjohnston merged 2 commits intodevelopfrom Feb 3, 2020
Merged
Fix stacktraces when using ObservableDeferred and async/await#6836erikjohnston merged 2 commits intodevelopfrom
erikjohnston merged 2 commits intodevelopfrom
Conversation
Member
|
For a little more detail: this property is read back when a new |
48 tasks
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'ae5b3104f': Fix stacktraces when using ObservableDeferred and async/await (#6836)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So
__failure__is a magic (undocumented) thing that twisted will look for when raising exception during anawait: https://github.com/twisted/twisted/blob/twisted-19.10.0/src/twisted/internet/defer.py#L748.Empirically this seems to Do The Right Thing, but it somewhat feels like we're working against Twisted here. Ideally there would be some sort of
ObservableDeferredin Twisted that handled this stuff properly, but there doesn't seem to be.