This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix syntax error in run_upgrade for schema 57#6728
Merged
erikjohnston merged 5 commits intomatrix-org:developfrom Jan 17, 2020
Merged
Fix syntax error in run_upgrade for schema 57#6728erikjohnston merged 5 commits intomatrix-org:developfrom
erikjohnston merged 5 commits intomatrix-org:developfrom
Conversation
erikjohnston
suggested changes
Jan 17, 2020
Member
erikjohnston
left a comment
There was a problem hiding this comment.
Thanks! So the underlying problem here is that postgres and sqlite have different formats for their SQL parameters (sqlite use ? but postgres uses %s). This is not usually a problem because we do a translation for postgres to convert ? to %s, but (for whatever reason) we don't do this for schema deltas, and so need to be done manually.
We still need your changes as well since we do still need to move the `%' out of the SQL to stop postgres from trying to understand it.
synapse/storage/data_stores/main/schema/delta/57/local_current_membership.py
Show resolved
Hide resolved
…_membership.py Co-Authored-By: Erik Johnston <erikj@jki.re>
erikjohnston
approved these changes
Jan 17, 2020
Member
|
Thank you again! |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '722b4f302': Fix syntax error in run_upgrade for schema 57 (#6728)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6727
Related #6655
#6727 (comment)