This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Silence mypy errors for files outside those specified#6512
Merged
erikjohnston merged 2 commits intodevelopfrom Dec 11, 2019
Merged
Silence mypy errors for files outside those specified#6512erikjohnston merged 2 commits intodevelopfrom
erikjohnston merged 2 commits intodevelopfrom
Conversation
richvdh
approved these changes
Dec 10, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
a file in config/ needs to import a class in storage/
this feels like a bad thing architecturally, tbh.
but otherwise lgtm
Member
Author
Its not ideal, but I think configuring mypy like this will help us expand our mypy coverage anyway |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '239d86a13': Newsfile Silence mypy errors for files outside those specified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for the database config splitting up PR, as a file in
config/needs to import a class instorage/, which then leads to lots and lots of errors.