This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Remove SnapshotCache in favour of ResponseCache#6506
Merged
erikjohnston merged 2 commits intodevelopfrom Dec 10, 2019
Merged
Conversation
richvdh
approved these changes
Dec 10, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
I think the timeout is important, but 🤷♂️
lgtm otherwise
Member
Author
|
Nothing should use global |
Member
|
OHHH |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'e3f528c54': Newsfile Remove SnapshotCache in favour of ResponseCache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only functional change here is to make the cache of
/initialSyncto expire immediately rather than after 5 minutes, bringing it in line with/sync. We can addtimeout_ms=5 * 60 * 1000if we want to bring them into line