This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Quick fix to ensure cache descriptors always return deferreds#6263
Merged
erikjohnston merged 3 commits intodevelopfrom Oct 29, 2019
Merged
Quick fix to ensure cache descriptors always return deferreds#6263erikjohnston merged 3 commits intodevelopfrom
erikjohnston merged 3 commits intodevelopfrom
Conversation
richvdh
reviewed
Oct 29, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
lgtm, although the docstring on CacheListDescriptor says that the wrapped function can return an immediate result, which is now untrue.
richvdh
approved these changes
Oct 29, 2019
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '561133c3c': Update docstring Newsfile Quick fix to ensure cache descriptors always return deferreds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a quick fix that wraps non-deferred results in deferreds when we return from the descriptors. We should/could also rip out the code that causes the underlying caches to swap out the ObservableDeferreds for unwrapped results, but that is more fiddly and invasive (and I don't know how this effects memory usage of caches).
I don't know how this effects CPU performance.