Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add m.id_access_token flag#5930

Merged
anoadragon453 merged 4 commits intodevelopfrom
anoa/m_id_access_token
Aug 30, 2019
Merged

Add m.id_access_token flag#5930
anoadragon453 merged 4 commits intodevelopfrom
anoa/m_id_access_token

Conversation

@anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Aug 29, 2019

Adds a flag to /versions' unstable_features section indicating that this Synapse understands what an id_access_token is, as per #5927 (comment)

Fixes #5927

@anoadragon453 anoadragon453 requested a review from a team August 29, 2019 10:57
@turt2live turt2live mentioned this pull request Aug 29, 2019
Merged
richvdh
richvdh approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming that we do indeed support the features indicated by the flag, lgtm

@richvdh
Copy link
Member

richvdh commented Aug 30, 2019

(could you link to the PR(s) which added the relevant support, for future reference?)

@jryans
Copy link
Contributor

jryans commented Aug 30, 2019

(could you link to the PR(s) which added the relevant support, for future reference?)

For Riot Web at least, this was done in matrix-org/matrix-js-sdk#1022.
For Riot iOS, work is in progress under element-hq/element-ios#2603.
For Riot Android, work has not yet happened yet under element-hq/riot-android#3228.

@anoadragon453
Copy link
Member Author

anoadragon453 commented Aug 30, 2019

@richvdh Assume you want to wait for this to merge before MSC'ing happens?

@anoadragon453
Copy link
Member Author

anoadragon453 commented Aug 30, 2019

And speaking of which, the MSC has gone into FCP: matrix-org/matrix-spec-proposals#2264

@anoadragon453 anoadragon453 merged commit 4765f0c into develop Aug 30, 2019
@anoadragon453 anoadragon453 deleted the anoa/m_id_access_token branch August 30, 2019 14:22
@richvdh
Copy link
Member

richvdh commented Aug 30, 2019

(could you link to the PR(s) which added the relevant support, for future reference?)

For Riot Web at least, this was done in matrix-org/matrix-js-sdk#1022.
For Riot iOS, work is in progress under vector-im/riot-ios#2603.
For Riot Android, work has not yet happened yet under vector-im/riot-android#3228.

Thanks for this, but I was really looking for where the synapse support was added...

@anoadragon453
Copy link
Member Author

anoadragon453 commented Aug 30, 2019 •
edited
Loading

Oh you mean where we accept the id_access_token parameter?

That is added as part of #5892

anoadragon453 added a commit that referenced this pull request Aug 30, 2019
@anoadragon453
Revert "Add m.id_access_token flag (#5930)"
6df0ff0 
This reverts commit 4765f0c.
@anoadragon453 anoadragon453 mentioned this pull request Aug 30, 2019
Merged
anoadragon453 added a commit that referenced this pull request Aug 30, 2019
@anoadragon453
Revert "Add m.id_access_token flag (#5930)" (#5945)
2a012e8 
This reverts commit 4765f0c.
@anoadragon453 anoadragon453 mentioned this pull request Aug 30, 2019
Closed
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Add m.id_access_token flag (#5930)
403e359 
Adds a flag to `/versions`' `unstable_features` section indicating that this Synapse understands what an `id_access_token` is, as per #5927 (comment)

Fixes #5927
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Revert "Add m.id_access_token flag (#5930)" (#5945)
0b2375d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@richvdh richvdh richvdh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

z-privacy-sprint (Deprecated Label)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anoadragon453 @richvdh @jryans