This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Prevent double group invites from breaking a group#3128
Closed
vurpo wants to merge 2 commits intomatrix-org:developfrom
Closed
Prevent double group invites from breaking a group#3128vurpo wants to merge 2 commits intomatrix-org:developfrom
vurpo wants to merge 2 commits intomatrix-org:developfrom
Conversation
Rephrase v0.28.0-rc1 summary
(which previously broke the group completely)
Member
|
Can one of the admins verify this patch? |
1 similar comment
Member
|
Can one of the admins verify this patch? |
Member
|
thanks :) this needs to handle the users table too, as well as clean out dups before adding the indexes. as these are pretty major changes, rather than clobbering your PR i've made a new one which supersedes this one. #3129 |
This was referenced May 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2633. This just changes a constraint in the database schema to be unique, so that any attempt to invite a user to a group twice will just return a 500 error, and not break the database.
I don't know what would happen if you applied this update to an already-broken database, though. Maybe there should be an SQL statement before this one that deletes any duplicate group invites before attempting to add the unique requirement?