This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Move RoomMemberHandler out of Handlers#2926
Merged
erikjohnston merged 2 commits intodevelopfrom Mar 1, 2018
Merged
Conversation
richvdh
approved these changes
Mar 1, 2018
Member
richvdh
left a comment
There was a problem hiding this comment.
lgtm, though I'm not sure i'd pull is_mine and is_mine_id into the handler.
synapse/handlers/room_member.py
Outdated
| if not is_host_in_room: | ||
| inviter = yield self.get_inviter(target.to_string(), room_id) | ||
| if inviter and not self.hs.is_mine(inviter): | ||
| if inviter and not self.is_mine(inviter): |
Member
There was a problem hiding this comment.
is there a reason to change this?
Member
Author
There was a problem hiding this comment.
TBH I was mostly using it so that I could track down all the various places we were doing annoying hs.get_*() calls. Am happy to put them back
ara4n
added a commit
that referenced
this pull request
Mar 13, 2018
…state_key is None) (#2990) Fixes a regression that had crept in where the caching layer upholds requests for loading state which is filtered by type (but not by state_key), but the DB layer itself would interpret a missing state_key as a request to filter by null state_key rather than returning all state_keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allows us to create it on workers.