Add reason why the archive bot is joining the room#262
Merged
MadLittleMods merged 9 commits intomainfrom Jun 9, 2023
Merged
Conversation
Using the join `reason` added in MSC2367 Related to adding some better profile information, #257 (comment)
Mikaela
reviewed
Jun 6, 2023
Mikaela
reviewed
Jun 6, 2023
| body: { | ||
| reason: | ||
| `Joining room to check history visibility. ` + | ||
| `If your room is public with shared or world readable history visibility, ` + |
There was a problem hiding this comment.
I think this is hostile wording towards the users as the term shared doesn't appear outside of the spec. Please consider using client terminology such as Element Web members-only?
Contributor
Author
There was a problem hiding this comment.
I've updated the FAQ with the equivalents you might see in the UI but it's not possible to be exhaustive for how every client might expose these options. We're also trying to be brief and to the point with this join reason so I'm going to just let the pointer to the FAQ take the lead for people trying to understand more.
Mikaela
reviewed
Jun 6, 2023
Mikaela
reviewed
Jun 6, 2023
I believe element android shows them. Not sure if its on join though. |
Mikaela
reviewed
Jun 7, 2023
Co-authored-by: Aminda Suomalainen <suomalainen+git@mikaela.info>
Contributor
Author
MadLittleMods
added a commit
that referenced
this pull request
Jun 9, 2023
This was referenced Jun 22, 2023
MadLittleMods
added a commit
that referenced
this pull request
Jun 22, 2023
Fix #267 In the case of someone visiting a room via an alias, we can't get access to the `room_id` before we join the room. I've opted to just point to the Matrix Public Archive instance in general. This way the `join` reason is always stable regardless how someone is visiting the room. Join `reason` was originally added in #262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add reason why the archive bot is joining the room
Using the join
reasonadded in MSC2367. Unfortunately, this PR doesn't have much effect because it doesn't look like many clients support it yet (Element doesn't support it for example).Part of #257