Add a way to jump forwards and backwards to more activity in the room#114
Merged
MadLittleMods merged 14 commits intomainfrom Nov 2, 2022
Merged
Add a way to jump forwards and backwards to more activity in the room#114MadLittleMods merged 14 commits intomainfrom
MadLittleMods merged 14 commits intomainfrom
Conversation
See `shows no events summary when no messages at or before the given day`
6 tasks
Conflicts: shared/hydrogen-vm-render-script.js
… jumping forwards
MadLittleMods
added a commit
to element-hq/hydrogen-web
that referenced
this pull request
Nov 2, 2022
…op as well and continue reading See `?continue=top` in matrix-org/matrix-viewer#114 for how this is used
MadLittleMods
added a commit
to element-hq/hydrogen-web
that referenced
this pull request
Nov 2, 2022
…op as well and continue reading See `?continue=top` in matrix-org/matrix-viewer#114 for how this is used
3 tasks
MadLittleMods
added a commit
that referenced
this pull request
Nov 3, 2022
Fix #120 Follow-up to #114 - Uses event permalinking (`?at=$xxx`) to continue the scroll where you should start reading again. - When we jump forwards, we make sure that we go a day back to ensure there isn't more than the page limit between where we jumped from and the day so we don't lose any messages in a gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a way to jump forwards and backwards to more activity in the room (
seamless navigation12).Fix #46
Follow-up to #71
Summary:
?continue=top[1]: See #120
[2]: There is a caveat with seamless here which is also commented on in the code:
(need forwards fill MSC)
Todo
stickToBottomonrestoreScrollPositionTimelineViewinstead ofRoomViewto pass the options directly and would align with @bwindels suggestion -> Refactor to useTimelineView#117?scroll=top,?continue=top/jump. Just move to the next day so we can display the no chat messages view