Fix /refresh endpoint to be V1 instead of V3#1289
Fix /refresh endpoint to be V1 instead of V3#1289TobiasFella wants to merge 1 commit intomatrix-org:mainfrom
Conversation
|
Does that effectively mean that refresh tokens do not exist in the wild despite being specced for half a year? |
|
Seemingly so, but that wasn't really the requirement for implementation on that MSC. |
|
Wait, I actually don't see it being an r0 endpoint in scope for MSC2844. |
|
All endpoints in the spec at the time of MSC2844 landing were in scope - that includes MSC2918 which was specified as an r0 endpoint and landed in the same spec version as MSC2844, ergo became |
|
err, sorry: point of clarification on the refresh tokens bits: since it got merged as |
|
for even more clarity on the timeline:
With this timeline in mind, MSC2918 was in fact r0-stable at the time of Matrix 1.1 and thus subject to MSC2844's changes. |
As per matrix-org/matrix-spec#1289, the refresh token MSC landed before the new endpoint versioning scheme, which means the /refresh endpoint should be available as /r0 and /v3 instead of /v1 Signed-off-by: Tulir Asokan <tulir@maunium.net>
The implementations in synapse and matrix-js-sdk use this as /v1/refresh, which, according to @KitsuneRal, is correct
Signed-off-by: Tobias Fella fella@posteo.de
Preview: https://pr1289--matrix-spec-previews.netlify.app