room preview: use the room summary MSC3266 endpoint#3339
Conversation
Bingo, so disabling the test on CI. |
f06855c to
d128cb5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
- Coverage 83.63% 83.55% -0.09%
==========================================
Files 241 241
Lines 24873 24899 +26
==========================================
+ Hits 20803 20804 +1
- Misses 4070 4095 +25 ☔ View full report in Codecov by Sentry. |
d128cb5 to
fc2d217
Compare
Honestly, I'm not sure how the retry-after that's a fixed point in time in the future should be handled, open to suggestions here…
fc2d217 to
a57b003
Compare
|
@Hywan Can haz review, plz? Okthxbye 🥺 |
|
ruma/ruma#1776 has been merged 😉. |
Hywan
left a comment
There was a problem hiding this comment.
Looks good to me. Please fix the repository of Ruma before merging this PR.
| imbl = "2.0.0" | ||
| itertools = "0.12.0" | ||
| ruma = { git = "https://github.com/ruma/ruma", rev = "4c00bd010dbdca6005bd599b52e90a0b7015d056", features = [ | ||
| ruma = { git = "https://github.com/ruma/ruma", rev = "21b644ac6ae1c7d4a4f7e98a6481a3318f2deeaa", features = [ |
There was a problem hiding this comment.
Please use the original repository since your PR has been merged.
There was a problem hiding this comment.
Agreed to use the original repo, which I've done in a commit this morning,… so there's nothing to change, right? 😁
This adds support for MSC3266 when fetching a room preview, for servers that support it. If the server doesn't support it, we resort to using the room state event endpoint.
Pretty sure the integration testing in CI will hate this, since I'm unit-testing the
from_room_summarymethod, which requires an experimental feature to be enabled on the synapse service. If that's the case, I'll disable this test.Using a fork of Ruma to cut corners, since the review of the feature there is getting complicated. Maybe ruma/ruma#1776 will get approved some day soon 🥲