client-api: add unstable MSC3266 support (room summary)#1776
Merged
client-api: add unstable MSC3266 support (room summary)#1776
Conversation
Kladki
requested changes
Apr 16, 2024
Contributor
Kladki
left a comment
There was a problem hiding this comment.
You also need to add an unstable feature for this in ruma and ruma-client-api
ede426e to
c6d5a2c
Compare
8e8f531 to
b15fa72
Compare
b15fa72 to
7334c2c
Compare
Kladki
requested changes
Apr 18, 2024
Co-authored-by: Matthias Ahouansou <matthias@ahouansou.cz>
Kladki
approved these changes
Apr 18, 2024
zecakeh
requested changes
Apr 18, 2024
Contributor
zecakeh
left a comment
There was a problem hiding this comment.
In the MSC there are also changes to the hierarchy endpoints, could you add those for completeness?
Co-authored-by: Kévin Commaille <76261501+zecakeh@users.noreply.github.com>
Co-authored-by: Kévin Commaille <76261501+zecakeh@users.noreply.github.com>
Contributor
Author
Not sure what you're talking about, and please let's not scope-creep by requesting more work; there's been already enough time spent on this PR :-) |
zecakeh
approved these changes
Apr 21, 2024
Contributor
Author
|
Thanks @zecakeh for the review ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements experimental support for MSC3266 for getting a room summary, which is really nice to get room previews even for rooms one is not part of.
Preview Removed