Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

[Backport staging] Fix checkForPreJoinUISI for thread roots#9816

Merged
turt2live merged 1 commit intostagingfrom
backport-9803-to-staging
Dec 21, 2022
Merged

[Backport staging] Fix checkForPreJoinUISI for thread roots#9816
turt2live merged 1 commit intostagingfrom
backport-9803-to-staging

Conversation

@RiotRobot
Copy link
Contributor

@RiotRobot RiotRobot commented Dec 21, 2022 •
edited by github-actions bot
Loading

Backport dd88fbb from #9803.

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • [Backport staging] Fix checkForPreJoinUISI for thread roots (#9816). Contributed by @RiotRobot.

@richvdh @github-actions
Fix checkForPreJoinUISI for thread roots (#9803)
d3a1ee3 
* Fix blank timeline when thread root is UTD

* add test for pre join uisi checks and thread roots

* ts strict fix

* Update to timeline panel test

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Fixes to TimelinePanel-test

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
(cherry picked from commit dd88fbb)
@RiotRobot RiotRobot requested a review from a team as a code owner December 21, 2022 16:06
@RiotRobot RiotRobot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems X-Release-Blocker This affects the current release cycle and must be solved for a release to happen labels Dec 21, 2022
@RiotRobot RiotRobot requested review from florianduros and t3chguy and removed request for a team December 21, 2022 16:06
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Dec 21, 2022
@t3chguy
Copy link
Member

t3chguy commented Dec 21, 2022

Cypress and ESLint failures expected

turt2live
turt2live approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a backport

@turt2live turt2live merged commit e0fe177 into staging Dec 21, 2022
@turt2live turt2live deleted the backport-9803-to-staging branch December 21, 2022 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@turt2live turt2live turt2live approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems X-Release-Blocker This affects the current release cycle and must be solved for a release to happen Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RiotRobot @t3chguy @turt2live