This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Mark the threads icon as unread due to activity.#9739
Closed
clokep wants to merge 4 commits intomatrix-org:developfrom
Closed
Mark the threads icon as unread due to activity.#9739clokep wants to merge 4 commits intomatrix-org:developfrom
clokep wants to merge 4 commits intomatrix-org:developfrom
Conversation
Member
Author
|
Together with #9738 this fixes element-hq/element-web#23907; should likely use the same changelog. |
50ccc5b to
73bb851
Compare
clokep
commented
Dec 12, 2022
Comment on lines
+99
to
+101
| // Thread activity should appear on the icon. | ||
| mkThread({ room, client, authorId: client.getUserId()!, participantUserIds: ["@alice:example.org"] }); | ||
| expect(isIndicatorOfType(getComponent(room), "bold")).toBe(true); |
Member
Author
There was a problem hiding this comment.
This assertion is failing -- from adding some debug logs it seems like the thread is getting created after the assertion. I'm not sure what's going on.
3 tasks
Member
Author
|
Going to close this and rebase it on a reworked #9723. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #9723 & #9738 to properly show bold status in the threads icon:
Checklist
Sign-off given on the changes (see CONTRIBUTING.md)Here's what your changelog entry will look like:
🐛 Bug Fixes