Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Prefer using the canonical alias in spotlight search#9059

Merged
t3chguy merged 1 commit intorelease-v3.49.0from
justjanne/fix/spotlight-room-alias
Jul 15, 2022
Merged

Prefer using the canonical alias in spotlight search#9059
t3chguy merged 1 commit intorelease-v3.49.0from
justjanne/fix/spotlight-room-alias

Conversation

@justjanne
Copy link
Contributor

@justjanne justjanne commented Jul 15, 2022

Type: Defect
Related: #9055


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Prefer using the canonical alias in spotlight search (#9059). Contributed by @justjanne.

* Prefer using the canonical alias in spotlight search

Public rooms on other homeservers are not joinable via the roomId if they haven't been joined by other users on your homeserver.

* Ensure we call the action with the room_alias

* lint

* Drop display

* Always provide roomId

* Add rationale to room_id, room_alias

* whoops

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
@justjanne justjanne added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jul 15, 2022
@justjanne justjanne requested a review from a team as a code owner July 15, 2022 11:27
@justjanne justjanne requested review from andybalaam, t3chguy and weeman1337 and removed request for a team July 15, 2022 11:27
@t3chguy
Copy link
Member

t3chguy commented Jul 15, 2022

Test failure expected due to branch mismatch

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No obvious (to me) errors

@t3chguy t3chguy merged commit 85363ef into release-v3.49.0 Jul 15, 2022
@t3chguy t3chguy deleted the justjanne/fix/spotlight-room-alias branch July 15, 2022 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants