Starred_Messages_Feature/Outreachy by yaya-usman · Pull Request #8842 · matrix-org/matrix-react-sdk

yaya-usman · 2022-06-14T14:21:40Z

Task: vector-im/element-web#22453

Signed-off-by: Yaya Usman yaya-usman@users.noreply.github.com

Type: enhancement

Here's what your changelog entry will look like:

✨ Features

Starred_Messages_Feature/Outreachy (#8842).

t3chguy

Clearing review while WIP, you can iterate on it with @andybalaam

andybalaam

This looks great. Setting my review to "Request changes" because we agreed that we will wait until the feature actually does something before merging.

src/components/views/messages/MessageActionBar.tsx

andybalaam

This looks really good. I don't understand all that useEffect stuff so we'll need someone else to review this, but when you have done all the things I commented on, we should be ready for someone else to review.

The hardest thing I asked for is more tests of the saving code. Feel free to ask me for help on that.

src/components/views/messages/MessageActionBar.tsx

src/contexts/FavMessageContext.tsx

src/dispatcher/actions.ts

src/contexts/FavMessageContext.tsx

src/components/views/messages/MessageActionBar.tsx

res/css/views/messages/_MessageActionBar.scss

SimonBrandner

Needs to be added to https://github.com/vector-im/element-web/blob/develop/docs/labs.md

src/contexts/FavouriteMessageContext.tsx

yaya-usman · 2022-07-05T11:36:16Z

Needs to be added to https://github.com/vector-im/element-web/blob/develop/docs/labs.md

Got it

t3chguy · 2022-07-06T13:44:04Z

This has conflicts and changes requested, please request a review once it is ready for review

andybalaam

Things left to resolve:

labs.md
unremove that blank line
Change the default export of FavouriteMessageContext.tsx to FavouriteMessageContext

src/dispatcher/actions.ts

SimonBrandner

Looking much better - thank you for the updates!

src/components/views/messages/MessageActionBar.tsx

src/hooks/useFavouriteMessages.ts

andybalaam

Looks good!

SimonBrandner

After further thought even though the way localStorage is used here isn't ideal, we can ignore it as it will soon be replaced

LGTM - thank you!

SimonBrandner · 2022-07-15T10:24:44Z

src/hooks/useFavouriteMessages.ts

+        localStorage.setItem('io_element_favouriteMessages', JSON.stringify(favouriteMessageIds));
+
+        //force update
+        setX([]);


Could you please add a comment about why is this necessary

stale

SimonBrandner

Thank you!

(will let Andy press the button; also, please fix the merge conflicts)

yaya-usman · 2022-07-15T19:48:16Z

Thank you!

(will let Andy press the button; also, please fix the merge conflicts)

Thanks but i don't know why i couldn't, it's weird

yaya-usman · 2022-07-15T19:49:06Z

SimonBrandner · 2022-07-15T19:49:47Z

You need to manually resolve them in your IDE/code editor

yaya-usman · 2022-07-15T19:50:09Z

This is what i meant, i don't know why i couldn't click the button, also i don't have any conflicts in my local version. So it's weird

yaya-usman · 2022-07-15T20:11:17Z

Thank you!

(will let Andy press the button; also, please fix the merge conflicts)

@SimonBrandner Andy asked me to click merge if i made the changes you requested and the checks passes. I hope it's ok by you. Also Thanks for the review!

SimonBrandner · 2022-07-15T20:12:18Z

Thank you!
(will let Andy press the button; also, please fix the merge conflicts)

@SimonBrandner Andy asked me to click merge if i made the changes you requested and the checks passes. I hope it's ok by you. Also Thanks for the review!

Sounds good 👍

@kerryarchibald

* Live location share - focus on user location on list item click ([\#9051](matrix-org/matrix-react-sdk#9051)). Contributed by @kerryarchibald. * Live location sharing - don't trigger unread counts for beacon location events ([\#9071](matrix-org/matrix-react-sdk#9071)). Contributed by @kerryarchibald. * Support for sending voice messages as replies and in threads ([\#9097](matrix-org/matrix-react-sdk#9097)). Fixes element-hq/element-web#22031. * Add `Reply in thread` button to the right-click message context-menu ([\#9004](matrix-org/matrix-react-sdk#9004)). Fixes element-hq/element-web#22745. * Starred_Messages_Feature_Contd_II/Outreachy ([\#9086](matrix-org/matrix-react-sdk#9086)). * Use "frequently used emojis" for autocompletion in composer ([\#8998](matrix-org/matrix-react-sdk#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt. * Improve clickability of view source event toggle button ([\#9068](matrix-org/matrix-react-sdk#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul. * Improve clickability of "collapse" link button on bubble layout ([\#9037](matrix-org/matrix-react-sdk#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul. * Starred_Messages_Feature/Outreachy ([\#8842](matrix-org/matrix-react-sdk#8842)). * Implement Use Case Selection screen ([\#8984](matrix-org/matrix-react-sdk#8984)). Contributed by @justjanne. * Live location share - handle insufficient permissions in location sharing ([\#9047](matrix-org/matrix-react-sdk#9047)). Contributed by @kerryarchibald. * Improve _FilePanel.scss ([\#9031](matrix-org/matrix-react-sdk#9031)). Contributed by @luixxiul. * Improve spotlight accessibility by adding context menus ([\#8907](matrix-org/matrix-react-sdk#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne. * Replace mask-images with svg components in MessageActionBar ([\#9088](matrix-org/matrix-react-sdk#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald. * Unbreak in-app permalink tooltips ([\#9087](matrix-org/matrix-react-sdk#9087)). Fixes element-hq/element-web#22874. * Show a back button when viewing a space member ([\#9095](matrix-org/matrix-react-sdk#9095)). Fixes element-hq/element-web#22898. * Align the right edge of info tile lines with normal ones on IRC layout ([\#9058](matrix-org/matrix-react-sdk#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul. * Prevent email verification from overriding existing sessions ([\#9075](matrix-org/matrix-react-sdk#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne. * Fix wrong buttons being used when exploring public rooms ([\#9062](matrix-org/matrix-react-sdk#9062)). Fixes element-hq/element-web#22862. * Re-add padding to generic event list summary on IRC layout ([\#9063](matrix-org/matrix-react-sdk#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul. * Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\#9055](matrix-org/matrix-react-sdk#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.

@kerryarchibald

* Live location share - focus on user location on list item click ([\matrix-org#9051](matrix-org#9051)). Contributed by @kerryarchibald. * Live location sharing - don't trigger unread counts for beacon location events ([\matrix-org#9071](matrix-org#9071)). Contributed by @kerryarchibald. * Support for sending voice messages as replies and in threads ([\matrix-org#9097](matrix-org#9097)). Fixes element-hq/element-web#22031. * Add `Reply in thread` button to the right-click message context-menu ([\matrix-org#9004](matrix-org#9004)). Fixes element-hq/element-web#22745. * Starred_Messages_Feature_Contd_II/Outreachy ([\matrix-org#9086](matrix-org#9086)). * Use "frequently used emojis" for autocompletion in composer ([\matrix-org#8998](matrix-org#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt. * Improve clickability of view source event toggle button ([\matrix-org#9068](matrix-org#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul. * Improve clickability of "collapse" link button on bubble layout ([\matrix-org#9037](matrix-org#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul. * Starred_Messages_Feature/Outreachy ([\matrix-org#8842](matrix-org#8842)). * Implement Use Case Selection screen ([\matrix-org#8984](matrix-org#8984)). Contributed by @justjanne. * Live location share - handle insufficient permissions in location sharing ([\matrix-org#9047](matrix-org#9047)). Contributed by @kerryarchibald. * Improve _FilePanel.scss ([\matrix-org#9031](matrix-org#9031)). Contributed by @luixxiul. * Improve spotlight accessibility by adding context menus ([\matrix-org#8907](matrix-org#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne. * Replace mask-images with svg components in MessageActionBar ([\matrix-org#9088](matrix-org#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald. * Unbreak in-app permalink tooltips ([\matrix-org#9087](matrix-org#9087)). Fixes element-hq/element-web#22874. * Show a back button when viewing a space member ([\matrix-org#9095](matrix-org#9095)). Fixes element-hq/element-web#22898. * Align the right edge of info tile lines with normal ones on IRC layout ([\matrix-org#9058](matrix-org#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul. * Prevent email verification from overriding existing sessions ([\matrix-org#9075](matrix-org#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne. * Fix wrong buttons being used when exploring public rooms ([\matrix-org#9062](matrix-org#9062)). Fixes element-hq/element-web#22862. * Re-add padding to generic event list summary on IRC layout ([\matrix-org#9063](matrix-org#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul. * Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\matrix-org#9055](matrix-org#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.

yaya-usman requested a review from a team as a code owner June 14, 2022 14:21

github-actions bot added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jun 14, 2022

yaya-usman requested a review from andybalaam June 14, 2022 14:24

yaya-usman self-assigned this Jun 14, 2022

github-actions bot deployed to Netlify June 14, 2022 14:26 View deployment

t3chguy marked this pull request as draft June 14, 2022 14:33

t3chguy reviewed Jun 14, 2022

View reviewed changes

andybalaam suggested changes Jun 15, 2022

View reviewed changes

src/components/views/messages/MessageActionBar.tsx Show resolved Hide resolved

github-actions bot deployed to Netlify June 25, 2022 19:45 View deployment

andybalaam suggested changes Jun 27, 2022

View reviewed changes

andybalaam mentioned this pull request Jun 27, 2022

Tracking issue for Favourite Messages element-hq/element-web#22453

Closed

31 tasks

github-actions bot deployed to Netlify July 1, 2022 09:16 View deployment

yaya-usman force-pushed the star_feature branch from 0ecd304 to fe4a389 Compare July 1, 2022 09:20

github-actions bot deployed to Netlify July 1, 2022 09:30 View deployment

github-actions bot deployed to Netlify July 2, 2022 12:40 View deployment

github-actions bot deployed to Netlify July 5, 2022 09:45 View deployment

andybalaam marked this pull request as ready for review July 5, 2022 11:16

SimonBrandner suggested changes Jul 5, 2022

View reviewed changes

github-actions bot deployed to Netlify July 5, 2022 11:21 View deployment

SimonBrandner reviewed Jul 5, 2022

View reviewed changes

src/contexts/FavouriteMessageContext.tsx Outdated Show resolved Hide resolved

src/contexts/FavouriteMessageContext.tsx Outdated Show resolved Hide resolved

yaya-usman requested a review from t3chguy July 6, 2022 13:42

t3chguy removed their request for review July 6, 2022 13:44

github-actions bot deployed to Netlify July 6, 2022 14:06 View deployment

yaya-usman requested a review from t3chguy July 6, 2022 14:27

andybalaam suggested changes Jul 12, 2022

View reviewed changes

github-actions bot deployed to Netlify July 12, 2022 11:27 View deployment

github-actions bot deployed to Netlify July 12, 2022 11:31 View deployment

yaya-usman mentioned this pull request Jul 12, 2022

Add docs for feature_favourite_messages element-hq/element-web#22818

Merged

github-actions bot deployed to Netlify July 12, 2022 12:24 View deployment

t3chguy previously requested changes Jul 12, 2022

View reviewed changes

src/dispatcher/actions.ts Outdated Show resolved Hide resolved

github-actions bot deployed to Netlify July 14, 2022 10:50 View deployment

github-actions bot deployed to Netlify July 14, 2022 11:00 View deployment

SimonBrandner reviewed Jul 14, 2022

View reviewed changes

yaya-usman force-pushed the star_feature branch from d5ccba1 to 6d47912 Compare July 14, 2022 11:05

github-actions bot deployed to Netlify July 14, 2022 11:09 View deployment

github-actions bot deployed to Netlify July 14, 2022 12:57 View deployment

yaya-usman requested a review from SimonBrandner July 14, 2022 12:58

SimonBrandner requested a review from t3chguy July 14, 2022 14:12

andybalaam approved these changes Jul 15, 2022

View reviewed changes

SimonBrandner approved these changes Jul 15, 2022

View reviewed changes

t3chguy removed their request for review July 15, 2022 13:55

yaya-usman enabled auto-merge July 15, 2022 19:39

SimonBrandner approved these changes Jul 15, 2022

View reviewed changes

nits fixes

017f489

yaya-usman force-pushed the star_feature branch from 1e7db74 to 017f489 Compare July 15, 2022 19:55

github-actions bot deployed to Netlify July 15, 2022 19:58 View deployment

yaya-usman merged commit 48552c2 into matrix-org:develop Jul 15, 2022

yaya-usman deleted the star_feature branch July 15, 2022 20:30

Uh oh!

Conversation

yaya-usman commented Jun 14, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Features

Uh oh!

t3chguy left a comment

Choose a reason for hiding this comment

Uh oh!

andybalaam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andybalaam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SimonBrandner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yaya-usman commented Jul 5, 2022

Uh oh!

t3chguy commented Jul 6, 2022

Uh oh!

andybalaam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SimonBrandner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andybalaam left a comment

Choose a reason for hiding this comment

Uh oh!

SimonBrandner left a comment

Choose a reason for hiding this comment

Uh oh!

SimonBrandner Jul 15, 2022

Choose a reason for hiding this comment

Uh oh!

SimonBrandner left a comment

Choose a reason for hiding this comment

Uh oh!

yaya-usman commented Jul 15, 2022

Uh oh!

yaya-usman commented Jul 15, 2022

Uh oh!

SimonBrandner commented Jul 15, 2022

Uh oh!

yaya-usman commented Jul 15, 2022

Uh oh!

yaya-usman commented Jul 15, 2022

Uh oh!

SimonBrandner commented Jul 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yaya-usman commented Jun 14, 2022 •

edited by github-actions bot

Loading