This repository was archived by the owner on Sep 11, 2024. It is now read-only.
RTL layout compatibility: bridges list on room settings page#8243
Merged
t3chguy merged 22 commits intomatrix-org:developfrom Apr 19, 2022
luixxiul:RoomSettingsDialogBridges
Merged
RTL layout compatibility: bridges list on room settings page#8243t3chguy merged 22 commits intomatrix-org:developfrom luixxiul:RoomSettingsDialogBridges
t3chguy merged 22 commits intomatrix-org:developfrom
luixxiul:RoomSettingsDialogBridges
Conversation
- CSS logical properties - Replace float with flexbox Set column-gap:10px to keep 10px space between column-icon and column-data Also: rename protocol-icon to protocolIcon Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Usage of wildcard should be minimised as it consumes resource more than necessary Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Remove padding:0 and border:0 of a list inside another list with proper nesting Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
fix the initial letter of the bridge at the center of the rectangle Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## develop #8243 +/- ##
========================================
Coverage 30.03% 30.03%
========================================
Files 881 881
Lines 50213 50213
Branches 12791 12791
========================================
Hits 15081 15081
Misses 35132 35132
|
luixxiul
commented
Apr 6, 2022
|
|
||
| span { | ||
| /* Correct letter placement */ | ||
| left: auto; |
Contributor
Author
There was a problem hiding this comment.
This might be no longer necessary thanks to box-sizing above, but I'll keep this for now.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Contributor
Author
|
Thank you very much for checking. I'm going to address them soon 😄 |
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
t3chguy
reviewed
Apr 13, 2022
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Member
|
Can you please pull latest develop |
Contributor
Author
|
Done, but it's stuck like this:
I'm not really sure what that means... |
Johennes
pushed a commit
to Johennes/matrix-react-sdk
that referenced
this pull request
Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses element-hq/element-web#14520 (#8217)
Current implementation:
LTR layout
RTL layout
The icon is moved to the left side because of the
float: right;. This PR fixes the bug by replacing float with flexbox (note: you could otherwise setfloat: leftfor the RTL layout by either replacing the current padding setting with a logical one and setting a specific className for the layout to a higher element).The position of the avatar inside pill is out of scope of this PR. It should be taken care of by #8217.
Multiple bridges:
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: task
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8243--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.