This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove the location type dropdown from the location picker#7486
Merged
andybalaam merged 1 commit intopsf-532-remove-descriptionfrom Jan 10, 2022
Merged
Remove the location type dropdown from the location picker#7486andybalaam merged 1 commit intopsf-532-remove-descriptionfrom
andybalaam merged 1 commit intopsf-532-remove-descriptionfrom
Conversation
turt2live
approved these changes
Jan 7, 2022
Member
turt2live
left a comment
There was a problem hiding this comment.
lgtm either way, though that comment's purpose being clarified would be good :)
Comment on lines
+36
to
+42
| /* | ||
| * An older version of this file allowed manually picking a location on | ||
| * the map to share, instead of sharing your current location. | ||
| * Since the current designs do not cover this case, it was removed from | ||
| * the code but you should be able to find it in the git history by | ||
| * searching for the commit that remove manualPosition from this file. | ||
| */ |
Member
There was a problem hiding this comment.
is this intending to document away any remaining oddities that were left behind (potentially) unintentionally? Not really sure what the comment is trying to inform the reader of.
Member
Author
There was a problem hiding this comment.
It's intended to help someone in the future resurrect the code, when we do want that functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #7485
Remove the dropdown for what type of location to share. We won't support this in the MVP.
Doesn't look very pretty yet - that will come later, following the designs we have.
Here's what your changelog entry will look like:
🐛 Bug Fixes
Preview: https://61d8752f62e38347d4d05595--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.