This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix size of portrait images with the SIZE_NORMAL setting.#7188
Merged
Fix size of portrait images with the SIZE_NORMAL setting.#7188
Conversation
now portrait images are drawn with the same width than landsape images.
turt2live
approved these changes
Nov 23, 2021
Member
turt2live
left a comment
There was a problem hiding this comment.
The code looks fine, though I'm a bit sad to see portrait images taking up even more space again - it feels like it defeats the purpose of the smaller image size setting.
e149d09 to
3b8dfbc
Compare
Contributor
Author
|
I revisited this PR and added another default value for portrait images. They are handled the same way (they are sized so that the width fits the requested width, EXCEPT if the height exceeds a maximum) but just use different default values now.
left old, right new |
gaelledel
approved these changes
Nov 29, 2021
Palid
pushed a commit
that referenced
this pull request
Nov 30, 2021
…om-alias * origin/develop: (118 commits) Allow filtering room list during treeview navigation (#7219) Improve room list message previews (#7224) Fix EmojiPicker lazy loaded rendering bug (#7225) Prevent default avatar in UserInfo having pointer cursor (#7218) Hide scrollbar if content height is smaller than scroll node height (#7220) Add option to disable grouping in TimelinePanel (#7221) Prevent duplicate avatars in Event List Summaries (#7222) Add right panel chat timeline (#7112) Task/colors 12 (reorganize theme files again) (#7212) Fix size of portrait images with the SIZE_NORMAL setting. (#7188) Task/colors 11 (#7211) Respect the home page as a context for the Home space (#7216) Fix RoomUpgradeWarningBar exploding (#7214) Hide server options hint when disable_custom_urls is true (#7215) Polish threads misalignments and UI diversion (#7209) Improve right panel resize handle usability (#7204) Fix multiline paragraph rendering as single line (#7210) Fix Manage Restricted Join Rule Dialog for Spaces (#7208) Spaces quick settings (#7196) re-enable Spaces e2e tests (#7207) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, portrait images are drawn with the same width than Landscape images.
This was the requested behavior from design..
This PR #7171 fixed a bug for really high images but also made portrait images not behave as desired anymore.
(see the comments in the changed files for the logic used to determine image sizes)
Left old, right new (for the large setting nothing changes)
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://619f6fe0dafa3d153dcf4a2f--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.