This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Use fallback avatar only for DMs with 2 people#6144
Closed
SimonBrandner wants to merge 4 commits intomatrix-org:developfrom
Closed
Use fallback avatar only for DMs with 2 people#6144SimonBrandner wants to merge 4 commits intomatrix-org:developfrom
SimonBrandner wants to merge 4 commits intomatrix-org:developfrom
Conversation
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Member
|
Needs product input as this ought to be consistent across Element clients |
andybalaam
added a commit
to andybalaam/matrix-react-sdk
that referenced
this pull request
Sep 30, 2021
jakewb-b
approved these changes
Oct 1, 2021
Member
|
I worked on some tests for this and added them at #6895 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#17559
Fixes element-hq/element-web#9929
Fixes element-hq/element-web#18747
This should cause the following behaviour if a room has no avatar: If a room is a DM and has two members, the other member's (the member that is not you) avatar will be used as the room avatar. In any other case, the first latter of the room name will be used.
Using an avatar of a user in a non-DM/a room with multiple people seems confusing
Here's what your changelog entry will look like:
✨ Features
Preview: https://6157120e7e455f00d5f336ee--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.