This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Clarify logout key backup warning dialog#5363
Closed
notramo wants to merge 1 commit intomatrix-org:developfrom
notramo:patch-1
Closed
Clarify logout key backup warning dialog#5363notramo wants to merge 1 commit intomatrix-org:developfrom notramo:patch-1
notramo wants to merge 1 commit intomatrix-org:developfrom
notramo:patch-1
Conversation
Member
|
@notramo this needs sign off and a |
Added details to the logout key backup warning dialog, why access to encrypted messages will be lost. Closes element-hq/element-web#15565
Collaborator
|
@notramo Hmm, seems like strings still don't match, did you run |
Contributor
Author
|
I don't know React or anything JS. It seemed trivial to patch it, but it is more complicated than I think. Could someone take it over? |
Contributor
I've re-created the PR based on the latest code ⏩ #8741 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added details to the logout key backup warning dialog, why access to encrypted messages will be lost.
Closes element-hq/element-web#15565
Signed-off by: notramo notramo@protonmail.com
Here's what your changelog entry will look like:
✨ Features