This repository was archived by the owner on Sep 11, 2024. It is now read-only.
fix bug in inviting users to a room#11082
Closed
behnambagi wants to merge 1 commit intomatrix-org:developfrom
Closed
fix bug in inviting users to a room#11082behnambagi wants to merge 1 commit intomatrix-org:developfrom
behnambagi wants to merge 1 commit intomatrix-org:developfrom
Conversation
Member
|
See the contributing guide for the sign-off this PR requires |
Contributor
|
Hello! Thanks for the contribution. Firstly, to address the previous comment, the contribution guide can be seen here: Secondly, there's still some odd behaviour here. When I was testing the code changes you made (added onto the current develop branch) I found the below. The behaviour to me seems unchanged from your initial bug report, although there may be something I'm missing: Screen.Recording.2023-06-21.at.09.20.24.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#25578
Here's what your changelog entry will look like:
🐛 Bug Fixes