#23838: 24-hours time format fixed#10011
#23838: 24-hours time format fixed#10011nawarajshah wants to merge 2 commits intomatrix-org:developfrom
Conversation
While exporting the chat, it forces AM / PM output instead of 24 hour format, and it is easily fixed by making hour12: false for toLocaleString function
|
This looks like a visual change so I'd expect to see a linked issue where we the change is agreed upon, as well as the before and after screenshots mentioned in CONTRIBUTING.md. You've also checked to say you've done DCO signoff but there's no signoff here. |
|
i am new on contributing, so if I check something that I shouldn't check, please let me know. after |
germain-gg
left a comment
There was a problem hiding this comment.
This code is used throughout the whole product and not only in the context of chat exports.
You will also need to write tests for this PR to be merged as per then contributing guidelines https://github.com/vector-im/element-web/blob/develop/CONTRIBUTING.mdA
|
Wouldn't using the user's preference for the 12/24 hour format better than hard coding it? Also using user's locale. |
I use the available option, it is not hard-coding I think. |
Fixing the issue from element-hq/element-web#23838
While exporting the chat, it forces AM / PM output instead of 24-hour format, and it is easily fixed by making hour12: false for the toLocaleString function
Checklist
Signed-off-by: Nawaraj Shah shah.nawaraj.ns@gmail.com
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.