Skip to content

MSC2540: Stricter event validation: JSON compliance#2540

Merged
turt2live merged 10 commits intomasterfrom
clokep/json-validation-room-ver
May 25, 2020
Merged

MSC2540: Stricter event validation: JSON compliance#2540
turt2live merged 10 commits intomasterfrom
clokep/json-validation-room-ver

Conversation

@clokep
Copy link
Member

@clokep clokep commented May 13, 2020 •
edited
Loading

@clokep clokep mentioned this pull request May 13, 2020
Merged
3 tasks
@turt2live turt2live added proposal A matrix spec change proposal proposal-in-review unassigned-room-version Remove this label when things get versioned. labels May 13, 2020
turt2live
turt2live approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise is looking great - thank you!

turt2live
turt2live approved these changes May 13, 2020
View reviewed changes
@clokep @turt2live
Specify the current stable room versions.
6757c60 
Co-authored-by: Travis Ralston <travpc@gmail.com>
clokep
clokep commented May 14, 2020
View reviewed changes
@turt2live
Copy link
Member

turt2live commented May 14, 2020

This seems pretty reasonable to me, and imo doesn't require an implementation to block it going forward in the process:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented May 14, 2020 •
edited by erikjohnston
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 14, 2020
@richvdh richvdh self-requested a review May 14, 2020 16:45
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label May 14, 2020
@clokep
Copy link
Member Author

clokep commented May 14, 2020

This seems pretty reasonable to me, and imo doesn't require an implementation to block it going forward in the process:

See matrix-org/synapse#7381 for an implementation.

@clokep clokep mentioned this pull request May 14, 2020
Merged
6 tasks
richvdh
richvdh reviewed May 15, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nitpicks

richvdh
richvdh reviewed May 15, 2020
View reviewed changes
clokep and others added 3 commits May 15, 2020 10:51
@clokep @richvdh
Fix grammar and typos from review.
0b6301a 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@clokep
Clarify the range of valid values.
007c8b5
@clokep
Clarify range a bit more.
e5fa76c
@richvdh richvdh self-requested a review May 19, 2020 16:49
@turt2live turt2live mentioned this pull request May 19, 2020
Merged
richvdh
richvdh reviewed May 20, 2020
View reviewed changes
@clokep @richvdh
Give more guidance on how invalid events should be handled.
0771671 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@mscbot
Copy link
Collaborator

mscbot commented May 20, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 20, 2020
@clokep clokep mentioned this pull request May 20, 2020
Open
This was referenced May 20, 2020
Closed
Closed
@turt2live turt2live self-assigned this May 21, 2020
turt2live added a commit that referenced this pull request May 21, 2020
@turt2live
Incorporate MSC2540 (Canonical JSON validation)
66ab480 
MSC: #2540
@turt2live turt2live mentioned this pull request May 21, 2020
Merged
@turt2live
Copy link
Member

turt2live commented May 21, 2020

Spec PR (for when this leaves FCP): #2563

@turt2live turt2live removed the unassigned-room-version Remove this label when things get versioned. label May 21, 2020
@mscbot
Copy link
Collaborator

mscbot commented May 25, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels May 25, 2020
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period labels May 25, 2020
@turt2live turt2live merged commit e422bad into master May 25, 2020
@richvdh
Copy link
Member

richvdh commented Jul 29, 2020

spec pr has been merged

@richvdh richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jul 29, 2020
@clokep clokep mentioned this pull request Feb 2, 2022
Closed
This was referenced May 25, 2022
Closed
Closed
@clokep clokep deleted the clokep/json-validation-room-ver branch May 17, 2023 12:23
@matrixbot matrixbot mentioned this pull request Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbkr dbkr dbkr left review comments

@uhoreg uhoreg uhoreg left review comments

@turt2live turt2live turt2live approved these changes

@richvdh richvdh richvdh left review comments

@erikjohnston erikjohnston erikjohnston left review comments

+1 more reviewer

@neilalexander neilalexander neilalexander left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@turt2live turt2live

Labels

kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@clokep @turt2live @mscbot @richvdh @neilalexander @dbkr @uhoreg @erikjohnston