Conversation
Member
Author
|
In the hope that this is relatively uncontentious: @mscbot fcp merge |
Collaborator
|
Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
turt2live
approved these changes
Jun 4, 2019
Member
Author
|
related: matrix-org/synapse#4364 |
Collaborator
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
turt2live
added a commit
that referenced
this pull request
Jun 5, 2019
Proposals: * [MSC2076](#2076) * [MSC2077](#2077) Implementation references: * matrix-org/synapse@00bf99f * matrix-org/synapse#5354 * matrix-org/synapse#5321 No known differences from the proposals are included here - alterations are accidental.
Member
|
Spec PR: #2080 (for when this clears FCP) |
Collaborator
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
Member
|
merged 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered: https://github.com/matrix-org/matrix-doc/blob/main/proposals/2076-enforce-validity-periods.md