Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 58.40% 58.40%
=======================================
Files 51 51
Lines 7000 7000
=======================================
Hits 4088 4088
Misses 2522 2522
Partials 390 390
☔ View full report in Codecov by Sentry. |
swedgwood
added a commit
to matrix-org/dendrite
that referenced
this pull request
Jul 19, 2023
- to use new symbols from matrix-org/gomatrixserverlib#403 that don't mention MSC2946
devonh
approved these changes
Jul 19, 2023
devonh
pushed a commit
that referenced
this pull request
Jul 21, 2023
Remove mentions of MSC2946, as it it part of the spec. (For matrix-org/dendrite#3134 ). Signed-off-by: `Sam Wedgwood <sam@wedgwood.dev>`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove mentions of MSC2946, as it it part of the spec. (For matrix-org/dendrite#3134 ).
Any chance outright removing the old names will break things? Does go support some kind of aliasing so we can keep some types alive with deprecation notices? Not sure.
Signed-off-by:
Sam Wedgwood <sam@wedgwood.dev>