Specify omitempty for some fields in DeviceListUpdateEvent#311
Merged
neilalexander merged 1 commit intomainfrom May 23, 2022
Merged
Specify omitempty for some fields in DeviceListUpdateEvent#311neilalexander merged 1 commit intomainfrom
omitempty for some fields in DeviceListUpdateEvent#311neilalexander merged 1 commit intomainfrom
Conversation
This should address the cause of matrix-org/synapse#12829. These fields are optional, so we should omit them if they are empty instead of sending `null`.
neilalexander
added a commit
to matrix-org/dendrite
that referenced
this pull request
May 23, 2022
kegsay
approved these changes
May 23, 2022
neilalexander
added a commit
to matrix-org/dendrite
that referenced
this pull request
May 23, 2022
* Update to matrix-org/gomatrixserverlib#311 * Update to squash commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address the cause of matrix-org/synapse#12829. These fields are optional, so we should omit them if they are empty instead of sending
null.