More tests for leaves during a partial state resync#617
Merged
DMRobertson merged 13 commits intomainfrom Feb 28, 2023
Merged
Conversation
added 9 commits
February 17, 2023 12:45
the resync cannot complete until we call FinishStateRequest
if someone else arrives.
e7488d7 to
2291653
Compare
2291653 to
52925fd
Compare
52925fd to
dcf42fb
Compare
H-Shay
reviewed
Feb 23, 2023
DMRobertson
commented
Feb 28, 2023
H-Shay
approved these changes
Feb 28, 2023
Contributor
H-Shay
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding these!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
Closes matrix-org/synapse#12802