Baby steps for testing leaves during a faster join#581
Merged
DMRobertson merged 3 commits intomainfrom Jan 12, 2023
Merged
Conversation
squahtx
approved these changes
Jan 11, 2023
Contributor
squahtx
left a comment
There was a problem hiding this comment.
lgtm!
Thoroughly logging what the test is doing in human-readable terms is a nice touch.
We've been lax at it when writing the previous tests and as a result it's been painful to understand where they're failing when they go wrong.
Contributor
Author
Glad you like it! (I was writing these as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of matrix-org/synapse#12802