ENH: set default color cycle to named color sequence#29808
Merged
dstansby merged 1 commit intomatplotlib:mainfrom Mar 28, 2025
Merged
ENH: set default color cycle to named color sequence#29808dstansby merged 1 commit intomatplotlib:mainfrom
dstansby merged 1 commit intomatplotlib:mainfrom
Conversation
rcomer
commented
Mar 26, 2025
| # color cycle for plot lines as list of string color specs: | ||
| # single letter, long name, or web-style hex | ||
| #axes.prop_cycle: cycler('color', 'tab10') | ||
| # color cycle for plot lines as either a named color sequence or a list |
Member
Author
There was a problem hiding this comment.
As well as being more succinct, this saves me 40 microseconds 🚀
In [4]: %timeit validate_cycler("cycler('color', 'tab10')")
80.9 μs ± 1.25 μs per loop (mean ± std. dev. of 7 runs, 10,000 loops each)
In [5]: %timeit validate_cycler("cycler('color', ['1f77b4', 'ff7f0e', '2ca02c', 'd62728', '9467bd', '8c564b', 'e377c2', '7f7f7f', 'bcbd22', '17becf'])")
122 μs ± 952 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)
lib/matplotlib/rcsetup.py
Outdated
| colors = [scalar_validator(v.strip()) for v in s if v.strip()] | ||
| except ValueError as ve: | ||
| ke_msg = str(ke)[1:-1] # strip off quote marks | ||
| raise ValueError(f'{ke_msg} and {ve}') |
Member
Author
There was a problem hiding this comment.
I'd welcome any feedback on a better way to do the exception handling here. This works to combine the error messages from the two options (see new test) but I feel like I'm missing something.
Member
There was a problem hiding this comment.
Can't you simply
raise ValueError(f'{s!r} is neither a color sequence name nor can it be interpreted as a list of colors')
Member
Author
There was a problem hiding this comment.
Ah, so my problem was trying to be too clever 😆
07a01d9 to
846e825
Compare
timhoffm
reviewed
Mar 26, 2025
Member
timhoffm
left a comment
There was a problem hiding this comment.
I would not bother to discuss the potential ambiguity of color sequence name and single-letter-colors-in-string. AFAIK the potential single letter colors are "rgbcmykw" and it's hard to make reasonable name from that. So I doubt this will ever turn up in practice.
lib/matplotlib/rcsetup.py
Outdated
| colors = [scalar_validator(v.strip()) for v in s if v.strip()] | ||
| except ValueError as ve: | ||
| ke_msg = str(ke)[1:-1] # strip off quote marks | ||
| raise ValueError(f'{ke_msg} and {ve}') |
Member
There was a problem hiding this comment.
Can't you simply
raise ValueError(f'{s!r} is neither a color sequence name nor can it be interpreted as a list of colors')
QuLogic
reviewed
Mar 27, 2025
7fd60fc to
2065369
Compare
timhoffm
approved these changes
Mar 27, 2025
dstansby
approved these changes
Mar 28, 2025
| #axes.prop_cycle: cycler('color', ['1f77b4', 'ff7f0e', '2ca02c', 'd62728', '9467bd', '8c564b', 'e377c2', '7f7f7f', 'bcbd22', '17becf']) | ||
| # color cycle for plot lines as list of string color specs: | ||
| # single letter, long name, or web-style hex | ||
| #axes.prop_cycle: cycler(color='tab10') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #29799
As mentioned in the issue, it is possible that someone could register a color sequence called something like "rygbk" and then it would be ambiguous whether to use the color sequence or interpret as single character colors. We agreed that the color sequence would take precedence in this situation. Should I actually document that precedence either in the user guide section or in a next-api-changes note? I think in practice it will come up very rarely if at all.
PR checklist